[Webkit-unassigned] [Bug 25884] WebKit needs a style linting tool

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25884





--- Comment #23 from Mark Rowe (bdash) <mrowe at apple.com>  2009-07-09 03:32:17 PDT ---
(From update of attachment 32510)
> diff --git a/WebCore/html/HTMLMarqueeElement.cpp b/WebCore/html/HTMLMarqueeElement.cpp
> index d62eaab..713b57d 100644
> --- a/WebCore/html/HTMLMarqueeElement.cpp
> +++ b/WebCore/html/HTMLMarqueeElement.cpp
> @@ -34,7 +34,7 @@ namespace WebCore {
>  
>  using namespace HTMLNames;
>  
> - // WinIE uses 60ms as the minimum delay by default.
> +    // WinIE uses 60ms as the minimum delay by default.
>  const int defaultMinimumDelay = 60;

This change is wrong.

> diff --git a/WebCore/page/mac/WebCoreViewFactory.h b/WebCore/page/mac/WebCoreViewFactory.h
> index d4dc821..0a32124 100644
> --- a/WebCore/page/mac/WebCoreViewFactory.h
> +++ b/WebCore/page/mac/WebCoreViewFactory.h
> @@ -150,7 +150,7 @@
>  + (WebCoreViewFactory *)sharedFactory;
>  @end
>  
> - at interface WebCoreViewFactory (SubclassResponsibility) <WebCoreViewFactory>
> + at interface WebCoreViewFactory(SubclassResponsibility) <WebCoreViewFactory>
>  @end

This doesn't match the style that we use for categories in Objective-C.

> - at interface WebDashboardRegion : NSObject <NSCopying>
> -{
> + at interface WebDashboardRegion : NSObject <NSCopying> {
>      NSRect rect;
>      NSRect clip;
>      WebDashboardRegionType type;

This doesn't match the style that we use for interface declarations in
Objective-C.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.