[Webkit-unassigned] [Bug 26940] [Chromium] Add a SQLite VFS for Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26940


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32476|review?                     |review-
               Flag|                            |




--- Comment #10 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-07-08 15:05:57 PDT ---
(From update of attachment 32476)
Looking much prettier -- two minor issues below:

> +String SQLiteFileSystem::appendDatabaseFileNameToPath(const String& path, const String& fileName)
> +{
> +    if (path.isEmpty())
> +        return fileName;
> +    else
> +        return path + "\\" + fileName;
> +}

Whoops. This is a Windows-ism. Can we use FileSystem.h magic here?

> +int chromiumDelete(sqlite3_vfs* vfs, const char* fileName, int syncDir)

unused param syncDir?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.