[Webkit-unassigned] [Bug 27094] [Chromium] Upstream V8 npruntime bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27094


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32474|review?                     |review+
               Flag|                            |




--- Comment #3 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-07-08 14:42:05 PDT ---
(From update of attachment 32474)
r=me, with nits:

> +// Commenting out the locks to avoid dependencies on chrome for now.
> +// Need a platform abstraction which we can use.
> +// static Lock StringIdentifierMapLock;
> +

Remove commented code.

> +// FIXME: Consider removing locks if we're singlethreaded already.
> +// static Lock IntIdentifierMapLock;

Ditto.

> +        // AutoLock safeLock(StringIdentifierMapLock);

Ditto.

> +    // AutoLock safeLock(IntIdentifierMapLock);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.