[Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16401





--- Comment #214 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-07-08 12:56:10 PDT ---
(In reply to comment #213)
> (In reply to comment #210)
> > Although I have NOT read all the comments in this bug, I'm going to assume
> > you've done a fair job of summarizing them repeatedly in recent comments.  To
> > reiterate your position:
> > 
> > - You believe the patch should be landed as-is, then iterated upon.
> 
>  i believe that that is a realistic and pragmatic approach.
> 
> > - You don't have time to break up the patch into smaller pieces.
> 
>  ... and neither do the other people who have worked on it, see:
> 
>     https://bugs.webkit.org/show_bug.cgi?id=16401#c195
> 
>  also neither will, i believe anybody else be willing to break it up;
>  because DOM is so entangled that to even _begin_ unravelling it is
>  tricky.
> 
> > The reviewer(s) have said:
> > 
> > - The patch must be broken up into smaller pieces before being reviewed
> > further.
> > 
> > I think the important take-away here is that no one has stated that the patch
> > may never be landed, just that it needs to be broken up, reviewed and landed in
> > pieces.
> 
>  that is extremely unlikely to happen.
> 
>  from a "high level", using empirical testing and using pyjamas-desktop,
>  the patch can be proven and demonstrated to work, and provide the
>  necessary functionality.
> 
>  two separate contributors (myself and also martin) utilised this "indirect"
>  method of testing (using pywebkitgtk) to verify and validate that the code
>  works.

After re-reviewing some of the comments, I think my comment that the patch
"must be broken up in to smaller pieces" may be worded too strongly.  In
Comment #76, breaking up the patch is suggested as a best practice for new
contributors and will lead to quicker turnaround (reviews) on posted patches,
but it's not a strict requirement.

However, since you're unwilling to break it up (and since willing to be
patient), the next step would be to post a new monolithic patch for review
addressing feedback in Comment #191 and Comment #194.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.