[Webkit-unassigned] [Bug 26790] ParserArenaDeletable should override delete

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26790





--- Comment #8 from Kwang Yul Seo <kwangyul.seo at gmail.com>  2009-07-08 10:26:29 PDT ---
(From update of attachment 32349)
>Index: JavaScriptCore/ChangeLog
>===================================================================
>--- JavaScriptCore/ChangeLog	(revision 45367)
>+++ JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2009-06-30  Kwang Yul Seo  <skyul at company100.net>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        ParserArenaDeletable should override delete
>+        https://bugs.webkit.org/show_bug.cgi?id=26790
>+
>+        ParserArenaDeletable overrides new, but it does not override delete.
>+        ParserArenaDeletable must be freed by fastFree
>+        because it is allocated by fastMalloc.
>+
>+        * parser/NodeConstructors.h:
>+        (JSC::ParserArenaDeletable::operator delete):
>+        * parser/Nodes.h:
>+
> 2009-06-29  David Levin  <levin at chromium.org>
> 
>         Reviewed by Oliver Hunt.
>Index: JavaScriptCore/parser/NodeConstructors.h
>===================================================================
>--- JavaScriptCore/parser/NodeConstructors.h	(revision 45367)
>+++ JavaScriptCore/parser/NodeConstructors.h	(working copy)
>@@ -39,6 +39,11 @@ namespace JSC {
>         return fastMalloc(size);
>     }
> 
>+    inline void ParserArenaDeletable::operator delete(void* p)
>+    {
>+        fastFree(p);
>+    }
>+
>     inline ParserArenaRefCounted::ParserArenaRefCounted(JSGlobalData* globalData)
>     {
>         globalData->parser->arena().derefWithArena(adoptRef(this));
>Index: JavaScriptCore/parser/Nodes.h
>===================================================================
>--- JavaScriptCore/parser/Nodes.h	(revision 45367)
>+++ JavaScriptCore/parser/Nodes.h	(working copy)
>@@ -109,6 +109,8 @@ namespace JSC {
>         // Objects created with this version of new are not deleted when the arena is deleted.
>         // Other arrangements must be made.
>         void* operator new(size_t);
>+
>+        void operator delete(void*);
>     };
> 
>     class ParserArenaRefCounted : public RefCounted<ParserArenaRefCounted> {

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.