[Webkit-unassigned] [Bug 27072] Split StorageNamespace and StorageArea into an interface and implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27072


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32435|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-07-08 10:21:00 PDT ---
(From update of attachment 32435)
> Index: WebCore/storage/StorageArea.cpp

> +#if PLATFORM(CHROMIUM)
> +#else
> +    return StorageAreaImpl::create(storageType, origin, syncManager);
>  #endif

I think this should be #if !PLATFORM(CHROMIUM) to avoid the #else, or
perhaps you should add a similar FIXME comment there as you do below:


> Index: WebCore/storage/StorageNamespace.cpp

> +#if PLATFORM(CHROMIUM)
> +    // FIXME: Implement.
> +#else
> +    return StorageNamespaceImpl::localStorageNamespace(path);
> +#endif

Otherwise, looks good to me.  R=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.