[Webkit-unassigned] [Bug 25205] XMLHttpRequest instance is not an instanceof XMLHttpRequest

Wed Jul 8 09:54:11 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=25205

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32434|review?                     |review-
               Flag|                            |

--- Comment #8 from Darin Adler <darin at apple.com>  2009-07-08 09:54:11 PDT ---
(From update of attachment 32434)
This seems OK, but not great. The design here is supposed to be that derived
classes override createStructure if the base class version doesn't work right.
Leaving behind a createStructure function that does the wrong thing and relying
on the callers to call the correct one seems unnecessarily fragile to me. To
share code, we could create a new base class, derived from DOMObject, and have
all the constructor classes derive from this, and it would override
createStructure to work properly.

Would you be willing to try that approach?

review- for now, but I'm open to landing this version if you don't like my
suggestion and can convince me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.