[Webkit-unassigned] [Bug 25884] WebKit needs a style linting tool

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25884


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32441|0                           |1
        is obsolete|                            |
  Attachment #32444|                            |review?
               Flag|                            |




--- Comment #16 from Shinichiro Hamaji <hamaji at chromium.org>  2009-07-08 03:58:32 PDT ---
Created an attachment (id=32444)
 --> (https://bugs.webkit.org/attachment.cgi?id=32444)
Fix for lint errors v2

Ah, thanks for the comment! Yeah, of course, it is better to check this patch
in. I didn't flag '?' as I didn't confirm it could be compiled with Mac. Now I
confirmed it can be compiled and I fixed the style of cast. Could you land this
patch? I think it's good if you can check this in soon. Otherwise, you may see
a lot of conflicts as this patch changes many code.

By the way, the warning for C-style casts is another example of warnings I
disabled. It would be nice if we can discuss which rule is necessary for
WebKit. As I'm a newbie of WebKit, I know few undocumented customs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.