[Webkit-unassigned] [Bug 27013] WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition for Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27013


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32399|review?                     |review-
               Flag|                            |




--- Comment #4 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-07-07 16:28:13 PDT ---
(From update of attachment 32399)
I'm concerned this may cause problems for the PLATFORM(QT) build.
I believe that in the PLATFORM(QT) builds on Windows, PLATFORM(WIN_OS)
will also be defined.

You may be able to avoid that problem by revising the #ifdefs to check
for PLATFORM(QT) before checking for PLATFORM(WIN_OS).

Also, the very last PLATFORM(WIN) in FileSystem.h might be best kept
as PLATFORM(WIN).  It looks like it is a declaration of additional
functions that perhaps only make sense in the PLATFORM(WIN) port
(i.e., Safari on Windows).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.