[Webkit-unassigned] [Bug 26953] [V8] Do not do unnecessary handles casts and inline couple of methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 10:35:34 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26953


anton muhin <antonm at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32384|                            |review?
               Flag|                            |




--- Comment #3 from anton muhin <antonm at chromium.org>  2009-07-07 10:35:33 PDT ---
Created an attachment (id=32384)
 --> (https://bugs.webkit.org/attachment.cgi?id=32384)
Addressing Mads' comments

Mads, thanks a lot for review!

I hope I addressed all your comments.  I don't know if we need this assert at
all, but I just don't want to touch it as my knowledge of bindings is currently
limited.  But if you all agree it should go away, I'd be more than happy to
remove it.

Sorry, original patch didn't compile cleanly in debug mode (some checks in
asserts), so I needed to through in some more changes, but of the similar
kind---don't downcast to v8::Value.

And I need a patch for webkit/glue part as well (sending it to you, guys).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list