[Webkit-unassigned] [Bug 27031] New: [WINCE] needs OwnPtr<HDC>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27031

           Summary: [WINCE] needs OwnPtr<HDC>
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joe.mason at torchmobile.com


Our WinCE port stores HDC's in an OwnPtr, so we added a deleteOwnedPtr override
for HDC.

I've enabled this for all Windows builds, because it seems useful for all of
them and will optimize out if it's not used.  I could easily change the patch
to define it for WINCE only if that's preferred.

Yong points out that only HDC's created with CreateCompatibleDC can be stored
in an OwnPtr - those returned by GetDC would be double-deleted.  I don't think
this is dangerous because it's the same situation with any resource that's
deleted by someone else: you don't own HDC's returned by GetDC, so you
shouldn't put them in an OwnPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.