[Webkit-unassigned] [Bug 27020] msToGregorianDateTime ignores outputIsUTC param when filling in utcOffset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27020





--- Comment #3 from Joe Mason <joe.mason at torchmobile.com>  2009-07-07 08:03:03 PDT ---
The most common idiom boils down to:

  msToGregorianDateTime(millisecs, outputIsUTC, t);
  if (outputIsUTC)
    // do something with t.month, t.year, etc. but not t.utcOffset
  else
    // do something with t.month, t.year, etc. adjusting for t.utcOffset

So the code path in this patch is followed, but in the case where utcOffset is
wrong it isn't used anyway.  I believe all calls to msToGregorianDateTime work
like this, but some of them are pretty complex so I can't be 100% sure.

We have this patch in our WinCE branch because at one point Google Calendar
didn't work for us without it.  I thought that it worked now, but I was
submitting it anyway because it seemed like the correct thing to do (and I
figured if not we would find that out during the code review.)

However, Yong thinks Google Calendar still doesn't work for us without this
patch.  I'm trying to find a test case now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.