[Webkit-unassigned] [Bug 25711] HTML5 Database becomes locked if a transaction is in progress when the page is refreshed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25711


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jmalonzo at gmail.com
         Resolution|                            |FIXED




--- Comment #39 from Jan Alonzo <jmalonzo at gmail.com>  2009-07-07 07:33:46 PDT ---
(In reply to comment #38)
> Created an attachment (id=32235)
 --> (https://bugs.webkit.org/attachment.cgi?id=32235) [details]
> Patch addressing Antti's final comments. (please submit this version of the
> patch)
> 
> Implements swap instead of a copy and changes the assert as per Antti's
> comments. As it's a small change to an r+'d patch I'm not marking the old patch
> obsolete so that this remains in the queue of bugs with patches ready to
> submit, hope that is OK.
> 
> Cheers, Ben

Landed in r45594. I fixed two style issues with the braces below before
landing. 

> +void DatabaseThread::recordDatabaseOpen(Database* database) {
> +    ASSERT(currentThread() == m_threadID);
> +    ASSERT(database);
> +    ASSERT(!m_openDatabaseSet.contains(database));
> +    m_openDatabaseSet.add(database);
> +}
> +
> +void DatabaseThread::recordDatabaseClosed(Database* database) {
> +    ASSERT(currentThread() == m_threadID);
> +    ASSERT(database);
> +    ASSERT(m_queue.killed() || m_openDatabaseSet.contains(database));
> +    m_openDatabaseSet.remove(database);
> +}
> +
>  void DatabaseThread::scheduleTask(PassRefPtr<DatabaseTask> task)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.