[Webkit-unassigned] [Bug 26963] Reproducible crash at FontCache::getFontData() when a custom font is used in a pseudo-style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26963


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32328|review?                     |
               Flag|                            |
  Attachment #32328|0                           |1
        is obsolete|                            |




--- Comment #7 from mitz at webkit.org  2009-07-06 18:25:22 PDT ---
(From update of attachment 32328)
(In reply to comment #6)
> (From update of attachment 32328 [details])
> I'm concerned about the addition of the new firstLineStyle method to
> RenderObject.  It seems like that is going to be confusing next to the other
> first line style method.

I will try to come up with a more descriptive/discouraging name.

> Would it be cleaner to just build this pseudo style comparison into the diff
> method?

I’ll try that and see where I get stuck :-)

Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.