[Webkit-unassigned] [Bug 26997] [Chromium] Remove buggy usage of DEFINE_STATIC_LOCAL in V8Binding.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 6 15:39:35 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26997





--- Comment #5 from Nate Chapin <japhet at chromium.org>  2009-07-06 15:39:34 PDT ---
To be honest, I'm not 100% sure what I did wrong here.  All I know is that I
clearly didn't initialize it correctly, because the test shell was consistently
crashing when lowNumbers[foo] was used a couple lines below the
DEFINE_STATIC_LOCAL().

I probably should have included a FIXME to use DEFINE_STATIC_LOCAL properly
instead of the traditional static variable declaration.  I just wanted to get
it working so that we could finish upstreaming V8Binding and get the chromium
canary builder green again.  

However, it's looking like I'm going to be rolling this change and the one that
introduced the bug back due to the chromium build mess and the fact that I
won't be able to clean up after myself tonight.  If someone can help me figure
out how to correctly use DEFINE_STATIC_LOCAL in this situation, I'll happily do
it right when I re-upstream V8Binding.cpp tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list