[Webkit-unassigned] [Bug 27010] New: Need to remove UsesManualToJSImplementation() in favor of CustomToJS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 6 15:24:10 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27010

           Summary: Need to remove UsesManualToJSImplementation() in favor
                    of CustomToJS
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore JavaScript
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: atwilson at google.com


CodeGeneratorJS.pm has some hard-coded logic which determines whether a toJS()
function should be defined in the JS binding header file, and whether an
implementation should be automatically generated.

This logic is:

.h file: define toJS() if the class in question is a base class (no parent
class) or if it has the GenerateToJS custom attribute.

.cpp file: automatically generate implementation of toJS() if the class in
question is a base class, but is not a member of a hardcoded list in
UsesManualToJSImplementation()

We should get rid of UsesManualToJSImplementation() in favor of a CustomToJS
attribute - the presence of this attribute will cause the code generator to
emit a toJS() definition in the generated .h file, but will not automatically
generate an implementation in the .cpp file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list