[Webkit-unassigned] [Bug 26982] Use soup's content sniffing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26982


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jmalonzo at gmail.com




--- Comment #4 from Jan Alonzo <jmalonzo at gmail.com>  2009-07-06 05:04:51 PDT ---
(In reply to comment #3)
> (From update of attachment 32279 [details])
> > -            , m_reportedHeaders(false)
> 
> Please don't forget to remove m_reportedHeaders decl too.
> 
> > +static void contentSniffedCallback(SoupMessage* msg, const char* sniffedType, GHashTable *params, gpointer data)
> > +{
> > +    if (sniffedType) {
> > +        const char* officialType = soup_message_headers_get_one(msg->response_headers, "Content-Type");
> > +
> > +        if (!officialType || strcmp(officialType, sniffedType))
> > +            soup_message_headers_set_content_type(msg->response_headers, sniffedType, params);
> > +    }
> 
> Ok. r=me.

FYI, this regressed three XHR tests (Debian amd64, unstable, ToT + this patch)

Running tests from /home/jmalonzo/OpenSource/WebKit/LayoutTests
Testing 77 test cases.
http/tests/xmlhttprequest ........
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html ->
failed
............
http/tests/xmlhttprequest/cache-override.html -> failed
...........................................
http/tests/xmlhttprequest/small-chunks-response-text.html -> failed
..
http/tests/xmlhttprequest/web-apps ...........
http/tests/xmlhttprequest/workers .
29.21s total testing time

74 test cases (96%) succeeded
3 test cases (3%) had incorrect layout
1 test case (1%) had stderr output
zsh: exit 1     WEBKITOUTPUTDIR=~/OpenSource/WebKit/build  --gtk --http
--no-new-test-results

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.