[Webkit-unassigned] [Bug 26827] Improve InlineBox::first/lastLeafChild methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26827





--- Comment #6 from Roland Steiner <rolandsteiner at google.com>  2009-07-06 04:31:36 PDT ---
(In reply to comment #5)

[recapping our discussion on IRC]

Note: all of the following is rather theoretical, since those function
currently are only called on RootInlineBox objects, while the issues would only
manifest if called on InlineFlowBox objects.

>From the name "firstLeafChild" it struck me as odd that the function would
potentially return a node outside the current subtree, i.e., not a child of the
current node.
The reason for this seems that the functions
firstLeafChildAfterBox/lastLeafChildBeforeBox are mainly for implementation
purposes, and used to implement both for first/lastLeafChild() and
next/prevLeafChild(). For the latter it makes sense that a node outside of the
current subtree can be returned, for the former not so much (IMHO).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.