[Webkit-unassigned] [Bug 26827] Improve InlineBox::first/lastLeafChild methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 6 00:47:44 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26827





--- Comment #4 from Maciej Stachowiak <mjs at apple.com>  2009-07-06 00:47:44 PDT ---
(From update of attachment 32103)
Most of the refactoring looks good. One part I don't undestand.

InlineFlowBox::firstLeafChildBeforeBox looks like it used to sometimes look in
the parent, if no leaf box was found:

     if (start && !leaf && parent())
         return parent()->firstLeafChildAfterBox(this);

Likewise for lastLeafChildBeforeBox. 

It's documented that these won't return nodes outside the subtree any more, but
as a non-expert it's not clear to me why this is right. Explanation would be
appreciated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list