[Webkit-unassigned] [Bug 26821] REGRESSION(r45285): focus rings are black on windows safari

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26821





--- Comment #16 from Jeremy Moskovich <playmobil at google.com>  2009-07-04 04:37:36 PDT ---
(In reply to comment #15)
> Just so i'm clear, is RenderThemeChromiumMac the only subclass that would want
> to set this custom color, that is, in the case of
> ChromiumBridge::layoutTestMode() ?

(sorry for not commenting earlier, but I've been travelling :( )

Not sure if this answers your question, but to the best of my knowledge,
there's no way to tell from inside WebKit whether you're running in layout test
mode, in the Chromium port ChromiumBridge::layoutTestMode() gives this
information.

The Mac port of Chromium aims to reuse the expected pixel results checked into
the tree and thus the focus ring color needs to match that used in the Mac
version of WebKit i.e. the behavior of RenderThemeMac.

RenderThemeMac in turn uses a fixed focus ring color in layout test mode,
rather than a color corrected focus ring color as is used in normal operation
(which to my understanding can change arbitrarily) in order to guarantee a
consistent focus ring color in pixel tests regardless of the system the tests
are run on.

RenderThemeMac uses a function defined in ColorMac that's toggled by DRT via an
accessor method in WebView in order to signal that we're in layout test mode so
it can use the "fixed" focus ring color.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.