[Webkit-unassigned] [Bug 26838] Multithread support for JSC on UNIX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26838


Maciej Stachowiak <mjs at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32117|review?                     |review-
               Flag|                            |




--- Comment #4 from Maciej Stachowiak <mjs at apple.com>  2009-07-03 16:52:43 PDT ---
(From update of attachment 32117)
Some style issues:

>#define SIG_THREAD_SUSPEND_RESUME SIGUSR2

I'd consider making this a static const int, rather than a #define. We prefer
to avoid preprocessor macros.


> static void pth_sig_suspend_resume(int signo)

This function should use WebKit naming style, for example
sendSuspendResumeSignal()


> -  markConservatively(static_cast<void*>(&regs), static_cast<void*>(reinterpret_cast<char*>(&regs) + regSize));
> +  if (regSize > 0)
> +              markConservatively(static_cast<void*>(&regs), static_cast<void*>(reinterpret_cast<char*>(&regs) + regSize));

This change seems unrelated to the rest of the patch. Please submit as a
separate patch or document the purpose of this change in the ChangeLog.


Also, since changes to this area can be performance-sensitive, please provide
before and after SunSpider results (as determined by the run-sunspider script
on the command line).

This patch looks great! r- for now to attend to the above issues, and please
resubmit with the requested revisions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.