[Webkit-unassigned] [Bug 25072] CSS21 attribute selectors not dynamic for xml

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25072


Kai Brüning <kai at granus.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30768|review?                     |
               Flag|                            |
  Attachment #30768|0                           |1
        is obsolete|                            |
  Attachment #32241|                            |review?
               Flag|                            |




--- Comment #11 from Kai Brüning <kai at granus.net>  2009-07-03 10:25:11 PDT ---
Created an attachment (id=32241)
 --> (https://bugs.webkit.org/attachment.cgi?id=32241)
New patch with more refactoring

I reworked the patch with a little refactoring of
StyledElement::attributeChanged() and Element::attributeChanged(). Now there
are no longer additional virtual function calls beyond the necessary.

Notes:
- The new function Element::recalcStyleIfNeededAfterAttributeChanged() would be
a candidate for inlining, but it can’t be inlined in Element.h without adding
include files.

- Element::recalcStyleIfNeededAfterAttributeChanged() uses document() instead
of ownerdocument() as StyledElement::attributeChanged() used to do. As far as I
can see this is completely safe in this case and faster, too. Please double
check, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.