[Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 2 18:12:33 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=17052





------- Comment #16 from yuzo at google.com  2009-07-02 18:12 PDT -------
Thank you for your review.

onmousemove side effect is not good. I need to fix it.

As to why Mac doesn't need this change:

As far as I tested, Mac OS always sends a mouse move event
after it sends a mouse wheel event. (So actually for Mac
I should disable the simulated event that this patch will
introduce.)

As for scroll by key event, on Mac the mouse cursor is
hidden when a key is pressed. Hence no need to update its shape.

I'll
- find a way to avoid onmousemove event
- disable the simulated event for mac
- add comments that explain why Mac works fine without this patch.
and get back to you.

Yuzo


(In reply to comment #15)
> Also, I will note that your current solution has observable side-effects. 
> JavaScript could detect your simulated mouse move events using onmousemove
> handlers.
> 

(In reply to comment #14)
> (From update of attachment 31822 [review])
> Ok.  What I need from you to r+ this patch, is I need explanation as to why
> this is the correct fix.  The fix itself looks fine, but why is this the right
> way to fix this?  Why does Mac not need this code for example?  Try the example
> on a Mac with a scroll wheel mouse and you'll see cursor updates work as
> expected.
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list