[Webkit-unassigned] [Bug 26857] [Chromium] Upstream V8Binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26857


levin at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32198|review?                     |review-
               Flag|                            |




------- Comment #8 from levin at chromium.org  2009-07-02 15:16 PDT -------
(From update of attachment 32198)
A few last things to address:

> Index: WebCore/bindings/v8/V8Binding.cpp
> +class WebCoreStringResource : public v8::String::ExternalStringResource {
> +public:
> +    explicit WebCoreStringResource(const String& string)
> +        : m_impl(string.impl()) { }

The { } should go on separate lines (since you have initializers).


> +String v8StringToWebCoreString(v8::Handle<v8::String> v8String, bool externalize)
> +{
...
> +
> +    int length = v8String->Length();
> +    if (length) {

if (!length)



> +String v8ValueToWebCoreString(v8::Handle<v8::Value> object)
> +{
...
> +        return webCoreString;
> +    } else {

This else should go away since there is a "return" finishing the previous
block.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.