[Webkit-unassigned] [Bug 26620] Haiku WebKit port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26620


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32076|review?                     |review-
               Flag|                            |




------- Comment #49 from eric at webkit.org  2009-07-02 14:49 PDT -------
(From update of attachment 32076)
What is a styleable port?
 45     // FIXME: subtract 1 from height and width? This was not done in
Syllable port

I don't think you meant to leaven this in:
 52     printf("FontCache::getFontDataForCharacters\n");    

WebKit generally uses 0 for NULL in C++ code:
 72     pcDefaultFont->GetFamilyAndStyle(&family, NULL);

Please use c++ style casts:
 76     //return new FontPlatformData(fontDescription, (BFont*)pcDefaultFont);

We don't commit commented out code:
 76     //return new FontPlatformData(fontDescription, (BFont*)pcDefaultFont);

Style:
83     if (!pcData->font())
 84     {

You should consider using an OwnPtr here:
 82     FontPlatformData* pcData = new FontPlatformData(fontDescription,
family);

Style:
 51 int char_unicode_to_utf8(unsigned short glyph, char* out) {

Tabs will cause the commit to fail:
54      if (glyph < 0x0080)
 55             out[i++] = (char)glyph;

Indent:
{
 74     notImplemented();
 75     return true;
 76 }

Why?
 43 int char_unicode_to_utf8(unsigned short glyph, char* out); // implemented
in FontDataHaiku.cpp

Please use C++ style casts:
 57     BView* view = (BView*)graphicsContext->platformContext();

Double converting to float:
 float Font::floatWidthForComplexText(const TextRun& run, HashSet<const
SimpleFontData*>* fallbackFonts) const
 83 {
 84     notImplemented();
 85     return 3.0;

Style:
59     if (f.m_font)
 60     {
 61         m_font = new BFont(f.m_font);
 62     }

Extra spaces and bad variable name:
 71     font_family     fam;

STyle:
 74     for(int i = 0; i < count_font_families(); i++) {


Please break this up into smaller patches.

Please do fewer patches per-bug.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.