[Webkit-unassigned] [Bug 26914] bugzilla-tool fails for SVN users

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26914





------- Comment #4 from levin at chromium.org  2009-07-01 22:01 PDT -------
I'll let Adam's r+ stand, but here are some comments to consider:

> diff --git a/WebKitTools/Scripts/modules/scm.py b/WebKitTools/Scripts/modules/scm.py
>  # All git-specific logic should go here.
> @@ -224,51 +234,56 @@ class Git(SCM):
> +    @staticmethod
> +    def commit_success_regexp():
> +        return "^Committed r(?P<svn_revision>\d+)\.$"

This shouldn't have a \. in it.

Here's a sample git svn dcommit message:

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
...
Committed r45448
        M       WebCore/ChangeLog
...
r45448 = 97e3c9608ffcf1f67fe127a738e043e2db154d7e (trunk)


>      def files_changed_summary_for_commit(self, commit_id):
> -        return self.run_command("git diff-tree --shortstat --no-commit-id " + commit_id)
> +        return self.run_command(['git', 'diff-tree', '--short-stat', '--no-commit-id', commit_id])

Why did the parameter change to from "--shortstat" to "--short-stat"?  (I
didn't see --short-stat listed as a valid option for "git diff-tree".)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.