[Webkit-unassigned] [Bug 26718] [Gtk] Add support for javascript windows for DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26718





--- Comment #10 from Gustavo Noronha (kov) <gns at gnome.org>  2009-07-12 04:21:37 PDT ---
(From update of attachment 32102)
> +    /**
> +    * WebKitWebSettings:javascript-can-open-windows
> +    *
> +    * Whether JavaScript can open popup windows automatically without user
> +    * intervention.

I think I would like to have the name of that setting contain -automatically,
to make it more obvious. So, javascript-can-open-windows-automatically. I know
it gets a bit too long, but there's no way someone would confuse what it does.
I'm good if there's a consensus on keeping it this way, though.

> +    gboolean                   (* close_web_view)         (WebKitWebView* web_view);
> +

Probably need to remove one of the paddings because of this new class method.
Or should we take the opportunity, break ABI, and also rename the library? =P

Take one out if you land before a decision is reached on breaking ABI, though.

Except for those two comments, r=me, with or without the rename, depending on
what you and xan think. I'm leaving the official r+ for Xan.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.