[Webkit-unassigned] [Bug 21575] Cairo's ImageBuffer::getImageData() does not handle alpha=0 case correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21575


krit at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24331|0                           |1
        is obsolete|                            |
  Attachment #27216|                            |review?
               Flag|                            |




------- Comment #6 from krit at webkit.org  2009-01-31 07:19 PDT -------
Created an attachment (id=27216)
 --> (https://bugs.webkit.org/attachment.cgi?id=27216&action=view)
imageData respects pre-multiplied colors

This fixes the pre-multiplied colors bug, as well as the alpha=0 case. It reads
the colors, given to the context, correctly but fails on the
canvas-getImageData test.
But the fact, that the context gets the wrong color and getImageData reads
exactly this color-settings, tells that getImageData works correctly. (see
https://bugs.webkit.org/show_bug.cgi?id=22150)
You can see the results of the test on the second attachment and the alpha of
the colors, given to the context and therefor to the ImageBuffer, on the third
attachement. You'll see, that the alpha channel is identical. (Haven't added
all colors, but the result is the same)

This patch passes canvas-putImageData.

I talked about platform dependencies on IRC (#cairo). And they assure me, that
this code is already endian safe.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.