[Webkit-unassigned] [Bug 23472] SVG pattern transformation/BoundingBox can cause ugly stroke thickness or text positions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23472


zimmermann at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27163|review?                     |review+
               Flag|                            |




------- Comment #7 from zimmermann at kde.org  2009-01-29 15:22 PDT -------
(From update of attachment 27163)
Looks nice, some comments:
> +        // Pattern space is an abstract space that maps to the default user space by the transformation matrix 
> +        // you specify with the userSpaceTransformation parameter.
> +        PlatformPatternPtr createPlatformPattern(const TransformationMatrix& userSpaceTransformation) const;

I'd shorten the comment:
> +        // Pattern space is an abstract space that maps to the default user space by the transformation 'userSpaceTransformation' 

Just leave out the comment for setPatternSpaceTransform, and make the argument
'const TransformationMatrix&'.
> +        void setPatternSpaceTransform(TransformationMatrix patternSpaceTransformation) { m_patternSpaceTransformation = patternSpaceTransformation; }

r=me with thse fixups.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.