[Webkit-unassigned] [Bug 21794] Middle-click panning should be springloaded while dragging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21794


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27160|review?                     |review+
               Flag|                            |




------- Comment #7 from aroben at apple.com  2009-01-29 14:21 PDT -------
(From update of attachment 27160)
> +#if ENABLE(PAN_SCROLLING)
> +    if (m_panScrollInProgress && !m_panScrollHasScrolled && panScrollDirection() != PanScrollNone) {
> +        m_panScrollHasScrolled = true;
> +    }
> +#endif

We normally leave off braces around single-line ifs. I can fix this up before
landing the patch.

> +    PanScrollDirection panScrollDirection();

I think this can be a const member function. I'll fix that, too.

Looks great!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.