[Webkit-unassigned] [Bug 23624] Expose a cross-platform NaN in MathExtras.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 29 13:11:17 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23624





------- Comment #3 from simon.fraser at apple.com  2009-01-29 13:11 PDT -------
Sorry to be vague. With this patch:

diff --git a/JavaScriptCore/wtf/MathExtras.h b/JavaScriptCore/wtf/MathExtras.h
index 76488b4..9638b35 100644
--- a/JavaScriptCore/wtf/MathExtras.h
+++ b/JavaScriptCore/wtf/MathExtras.h
@@ -28,6 +28,7 @@

 #include <math.h>
 #include <stdlib.h>
+#include <limits>

 #if PLATFORM(SOLARIS)
 #include <ieeefp.h>
@@ -44,7 +45,6 @@
 #else
 #include <xmath.h>
 #endif
-#include <limits>

 #if HAVE(FLOAT_H)
 #include <float.h>
@@ -68,6 +68,8 @@ const double piOverFourDouble = M_PI_4;
 const float piOverFourFloat = static_cast<float>(M_PI_4);
 #endif

+const double nanDouble = std::numeric_limits<double>::quiet_NaN();
+
 #if PLATFORM(DARWIN)

 // Work around a bug in the Mac OS X libc where ceil(-0.1) return +0.

I get link errors:

ld warning: symbol _ctiVMThrowTrampoline found in unsupported section in
/Volumes/InternalData/Development/WebKit/WebKit.git/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/i386/JIT.o
ld warning: symbol _ctiTrampoline found in unsupported section in
/Volumes/InternalData/Development/WebKit/WebKit.git/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/i386/JIT.o
Undefined symbols:
  "_ctiTrampoline", referenced from:
     
__ZN3JSC3JIT7executeEPvPNS_12RegisterFileEPNS_9ExecStateEPNS_12JSGlobalDataEPNS_10JSValuePtrE
in Interpreter.o
  "_ctiVMThrowTrampoline", referenced from:
      _ctiVMThrowTrampoline$non_lazy_ptr in Interpreter.o
ld: symbol(s) not found

I think this is because quiet_NaN() is declared as 
  double quiet_NaN() throw()
.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list