[Webkit-unassigned] [Bug 23625] Skia platform doesn't render text to a canvas or support clipping to an image buffer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 29 13:08:49 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23625


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27155|review?                     |review+
               Flag|                            |




------- Comment #2 from eric at webkit.org  2009-01-29 13:08 PDT -------
(From update of attachment 27155)
WebKit style omits names for arguments in headers when the names do not provide
additional clarity:

Like this:
+    void applyClipFromImage(const WebCore::FloatRect& rect, const SkBitmap&
imageBuffer);

neither rect or imageBuffer should be in the definition.

Otherwise this looks fine.  One of us can fix those nits when landing.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list