[Webkit-unassigned] [Bug 23551] Crash on page load with profiler enabled and running

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23551





------- Comment #14 from ggaren at apple.com  2009-01-29 12:57 PDT -------
> > The best solution is probably to pass "callFrame" rather than "newCallFrame" to
> > the profiler.
> 
> Won't that give the profiler the wrong lexical global object in some cases,
> giving the profiler the wrong profile group? Is that a problem? All
> fast/profiler tests pass and the crashes goes away.

I would pass "callFrame" both to willExecute and to didExecute. That will give
the profiler the lexical global object of the caller, which is what we want.
(We don't want to profile the function call if the caller is not being
profiled.)

It *would* be a slight error to pass newCallFrame to willExecute and callFrame
to didExecute. I believe Interpreter::execute for EvalNode and ProgramNode make
this mistake, and should probably be fixed.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.