[Webkit-unassigned] [Bug 23536] Auto-generate HTMLElementFactory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 29 11:18:50 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23536


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27057|review?                     |review-
               Flag|                            |




------- Comment #16 from eric at webkit.org  2009-01-29 11:18 PDT -------
(From update of attachment 27057)
This isn't ready yet.

Notice that image no longer uses the form element in your generated copy.  Your
generated copy also doesn't support disabling video? (maybe it doesn't need to
cause it generates w/o the video tags when video is off?)

I think the generated version should also use something like addTag for better
readability of the generated output.

There are a couple returns missing from the typedef line for the constructor
function at teh top of the line.

I would encourge you to fully sort the original file, and then generate yours
side by side and compare again.

This is really close, but we need it to be perfect before we can replace the
hand-rolled version or we'll have bugs!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list