[Webkit-unassigned] [Bug 21794] Middle-click panning should be springloaded while dragging

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 28 10:42:51 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=21794


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27098|review?                     |review-
               Flag|                            |




------- Comment #3 from aroben at apple.com  2009-01-28 10:42 PDT -------
(From update of attachment 27098)
Thanks for the patch!

> +#if ENABLE(PAN_SCROLLING)
> +        if (m_panScrollInProgress && mouseEvent.button() == MiddleButton  
> +            && selectPanScrollCursor().impl().type() != middlePanningCursor().impl().type()) {

I don't think this will compile on all platforms (most platforms'
PlatformCursor types do not have a type() function).

Loren's going to refactor this patch a bit to add something like a
panScrollingDirection() function that can be used both to decide the cursor and
to decide whether to do spring-loaded scrolling.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list