[Webkit-unassigned] [Bug 23536] Auto-generate HTMLElementFactory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23536


jchaffraix at pleyo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27027|0                           |1
        is obsolete|                            |
  Attachment #27045|                            |review?
               Flag|                            |




------- Comment #5 from jchaffraix at pleyo.com  2009-01-26 14:05 PDT -------
Created an attachment (id=27045)
 --> (https://bugs.webkit.org/attachment.cgi?id=27045&action=view)
Last bits of autogeneration hackery - Updated with Eric's comment

> Seems image should just pass another parameter.  MapToTagName="img" or
> something.

I used a parameter switch here (I could not find a better name that
mapToTagName so I used it).

> +    doc->setUsesBeforeAfterRules(true);
> 
> looks no worse than it was before, but is still not as elegant as it could be.
> You should add a FIXME that HTMLQuoteElements should set that flag on document
> insertion instead of construction.  I bet we could make a test where you create
> a Quote in one document, adopt it in another, and then before/after rules are
> not turned on for the document which adopted the quote!
> 

I agree with you: my goal was to get it out of HTMLElementFactory.cpp as we
could miss some quote elements but the logic is wrong. I have added the
requested FIXME.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.