[Webkit-unassigned] [Bug 23499] Add WML specific logic for WML <input>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 23 20:11:45 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23499





------- Comment #7 from zimmermann at kde.org  2009-01-23 20:11 PDT -------
(In reply to comment #6)
> > > +        if (m_formatMask.isEmpty() || 
> > > +            // check if the format codes is a "*f" code
> > > +           (m_formatMask.length() == 2 && m_formatMask[0] == '*' && s_formatCodes.find(m_formatMask[1]) != -1))
> > > +            m_isEmptyOk = true;
> > > +    }
> > This only takes care of the 'f' format code, what about the others?
> 
> That piece of code is to check the input mask with value of "*f" only.  so we
> need to check the length and whole string.
Yeah, it's just fine - but emptyok has to be handled as well for *A, *A, etc..
So I think we need to iterate over all possible combinations here, no?

> Good idea! It should be more like Webkit-style code.
> 
> Thanks a lot to let me learn more.

You're welcome! 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list