[Webkit-unassigned] [Bug 23492] Separating the WebKitSystemInterface Calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23492


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26983|review?                     |review+
               Flag|                            |




------- Comment #4 from darin at apple.com  2009-01-23 15:58 PDT -------
(From update of attachment 26983)
> +        https://bugs.webkit.org/show_bug.cgi?id=23492
> +        Exclude calls to WebKitSystemInterface functions since they
> +        are not available outside of the Apple build of WebKit.

Since they are not needed if you're not using Core Graphics. The issue here
isn't "Apple build of WebKit", it's "not calling CoreGraphics functions when
not using CoreGraphics".

> +#if PLATFORM(CG)
>  #include <CoreGraphics/CoreGraphics.h>
> +#include <WebKitSystemInterface/WebKitSystemInterface.h>
> +#endif
>  #include <shlobj.h>
>  #include <shfolder.h>
>  #include <tchar.h>
> -#include <WebKitSystemInterface/WebKitSystemInterface.h>
>  #include <wtf/HashMap.h>
>  #include <wtf/OwnArrayPtr.h>

The PLATFORM(CG) part should go in its own separate paragraph, after the other
includes and separate by a blank line. Sorry I wasn't clear on this before.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.