[Webkit-unassigned] [Bug 23488] Make TimerBase thread-aware. For use in Workers.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23488


dimich at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26964|review?                     |
               Flag|                            |
  Attachment #26964|0                           |1
        is obsolete|                            |
  Attachment #26985|                            |review?
               Flag|                            |




------- Comment #3 from dimich at chromium.org  2009-01-23 14:48 PDT -------
Created an attachment (id=26985)
 --> (https://bugs.webkit.org/attachment.cgi?id=26985&action=view)
Updated patch

Looking at it a bit more, fixed following:
- in multiple threads case, the timers can be created before worker thread
initializes SharedTimer, and SharedTimer pointer may be set to 0 before all the
timers are removed. Add check to avoid calling to SharedTimer when it's 0. (in
setSharedTimer, updateSharedTimer)

- made ThreadTimers::m_timerHeap an instance of a Vector rather then a pointer
to avoid it leaking when ThreadTimers gets destroyed (it does if its thread is
not a main one)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.