[Webkit-unassigned] [Bug 23428] Frame Refactor: Move forceLayout, adjustPageHeight, forceLa. to FrameView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23428


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26858|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2009-01-23 14:22 PDT -------
(From update of attachment 26858)
> +    // We cannot unschedule a pending relayout, since the force can be called with
> +    // a tiny rectangle from a drawRect update.  By unscheduling we in effect
> +    // "validate" and stop the necessary full repaint from occurring.  Basically any basic
> +    // append/remove DHTML is broken by this call.  For now, I have removed the optimization
> +    // until we have a better invalidation stategy. -dwh
> +    //v->unscheduleRelayout();

The "v->" no longer makes sense here.

>      if (minPageWidth > 0.0)
> -        coreFrame->forceLayoutWithPageWidthRange(minPageWidth, maxPageWidth, adjustViewSize);
> +        coreFrame->view()->forceLayoutWithPageWidthRange(minPageWidth, maxPageWidth, adjustViewSize);
>      else {
> -        coreFrame->forceLayout(!adjustViewSize);
> +        coreFrame->view()->forceLayout(!adjustViewSize);
>          if (adjustViewSize)
>              coreFrame->view()->adjustViewSize();
>      }

No need to null-check view() here? Are you sure?

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.