[Webkit-unassigned] [Bug 23508] New: Returns Blank Page for all "about" protocols

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23508

           Summary: Returns Blank Page for all "about" protocols
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: gen at staikos.net


loader/MainResourceLoader.cpp:
The function shouldLoadAsEmptyDocument() returns true for all "about" prefixed
pages (eg "about:config") pages which blocks the implementation of the about
protocol. Only "about:blank" should return true for a blank page.

I've included a patch and a log file.
2009-01-23  Genevieve Mak  <gen at staikos.net>

        Reviewed by NOBODY (OOPS!).

        Fix shouldLoadAsEmptyDocument() to return a blank page for an empty
        url or about:blamk

        * loader/MainResourceLoader.cpp:

diff --git a/WebCore/loader/MainResourceLoader.cpp
b/WebCore/loader/MainResourceLoader.cpp
index 325809b..57c9426 100644
--- a/WebCore/loader/MainResourceLoader.cpp
+++ b/WebCore/loader/MainResourceLoader.cpp
@@ -186,7 +186,7 @@ void MainResourceLoader::willSendRequest(ResourceRequest&
newRequest, const Reso

 static bool shouldLoadAsEmptyDocument(const KURL& url)
 {
-    return url.isEmpty() || equalIgnoringCase(String(url.protocol()),
"about");
+    return url.isEmpty() || (equalIgnoringCase(url.protocol(), "about") &&
equalIgnoringCase(url.path().stripWhiteSpace(), "blank"));
 }

 void MainResourceLoader::continueAfterContentPolicy(PolicyAction
contentPolicy, const ResourceResponse& r)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.