[Webkit-unassigned] [Bug 23374] Add RunLoop class to encapsulate the loop in Worker threads.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23374


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26906|review?                     |review+
               Flag|                            |




------- Comment #4 from ap at webkit.org  2009-01-23 00:49 PDT -------
(From update of attachment 26906)
> + * Copyright (c) 2009, Google Inc. All rights reserved.

Please fix the copyright line, as discussed on IRC.
>      // FIXME: Rudely killing the thread won't work when we allow nested workers, because they will try to post notifications of their destruction.
> -    m_messageQueue.kill();
> +    m_runLoop.terminate();

Do you happen to have a plan concerning this FIXME?

> +#include <WorkerRunloop.h>

Lower case "l" here, won't build on case-sensitive file systems.

r=me with these fixes.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.