[Webkit-unassigned] [Bug 23407] Implement MediaPlayerPrivate::hasVideo() on Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 23 00:49:43 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23407


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26958|review?                     |review-
               Flag|                            |




------- Comment #2 from eric at webkit.org  2009-01-23 00:49 PDT -------
(From update of attachment 26958)
WebKit style would not check != NULL (or use NULL at all)...

+    return (GetMovieIndTrackType(m_private->m_movie, 1,
VisualMediaCharacteristic, movieTrackCharacteristic | movieTrackEnabledOnly) !=
NULL);

Should be:
+    return GetMovieIndTrackType(m_private->m_movie, 1,
VisualMediaCharacteristic, movieTrackCharacteristic | movieTrackEnabledOnly);

Why is your test case being added to the platform/mac directory if this is a
windows test?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list