[Webkit-unassigned] [Bug 23435] Make SVG spreadMethod a member of Gradient rather than GraphicsContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23435


zimmermann at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26918|review?                     |review+
               Flag|                            |




------- Comment #15 from zimmermann at kde.org  2009-01-22 21:12 PDT -------
(From update of attachment 26918)
Most issues seem resolved, r=me - just one minor style issue:

> +        void setSpreadMethod(GradientSpreadMethod spreadMethod);
> +
> +        GradientSpreadMethod spreadMethod() { return m_spreadMethod; }
You can remove the newline between those methods, and omit the parameter name
in setSpreadMethod, so it just reads 'void
setSpreadMethod(GradientSpreadMethod);'

You don't need to upload another patch, just fix that issue before landing.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.