[Webkit-unassigned] [Bug 17733] execCommand with super/subscript doesn't toggle back to baseline

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 21 14:02:25 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=17733





------- Comment #12 from eric at webkit.org  2009-01-21 14:02 PDT -------
(In reply to comment #11)
> (In reply to comment #10)
> > (From update of attachment 26819 [review] [review])
> > -FAIL superscript removing vertical-align: superscript -- <span><span
> > class="Apple-style-span" style="vertical-align: super;">test</span></span>
> > +FAIL superscript removing vertical-align: superscript --
> > <span><sup>test</sup></span>
> > 
> > What's up here?
> 
> Hum... you're right.  That's still wrong.  I don't know how I didn't notice. 
> The <sup> tags shouldn't be there.

Ha!  Turns out the behavior was correct.  The test was incorrectly using
"vertical-align: superscript;" which is an invalid value (should be
"vertical-align: super"), thus the resulting resolved style was still
vertical-align: baseline, and the editing command worked as intended.  It
removed the bogus vertical-align value, and applied the superscript/subscript
using a "legacy" tag.

I'll upload the updated patch which I'm about to land.  Thanks again!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list