[Webkit-unassigned] [Bug 23435] Pass SVG spreadMethod to Gradient::platformGradient() and use it on Skia

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23435





------- Comment #3 from levin at chromium.org  2009-01-21 09:49 PDT -------
Just happened to look at this and saw a few things:

In WebCore/platform/graphics/cairo/GradientCairo.cpp, applySpreadMethod:
* case statements shouldn't be indented (in other places too)
* cairo_pattern_set_extend(pattern, CAIRO_EXTEND_PAD); is indented only 3
spaces.
* It should "return pattern;" at the end of the function.

In WebCore/platform/graphics/skia/GradientSkia.cpp,

  return m_gradient; 
got indented incorrectly.

  switch (spreadMethod) {
  ...
  default:

The default is going to prevent compiler warning/errors about unhandled enums
values (when this is an enum).  If you want to ensure that SkShader::TileMode
tile; is initialized (which is great), then do SkShader::TileMode tile =
SkShader::kClamp_TileMode;


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.