[Webkit-unassigned] [Bug 23435] Pass SVG spreadMethod to Gradient::platformGradient() and use it on Skia

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 21 08:41:47 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23435


zimmermann at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26864|review?                     |review-
               Flag|                            |




------- Comment #2 from zimmermann at kde.org  2009-01-21 08:41 PDT -------
(From update of attachment 26864)
This patch looks great! Though you should pass around the enum, instead of an
integer. This could be achieved by moving GradientSpreadMethod from
GraphicsContext.h to GraphicsTypes.h, and including GraphicsTypes.h in both
GraphicsContext.h and Gradient.h. What do you think?

r- because of that.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list