[Webkit-unassigned] [Bug 20721] mingw32 cross-compile from linux: VK_BACK and friends already #defined

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20721


camaradetux at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |camaradetux at gmail.com




------- Comment #2 from camaradetux at gmail.com  2009-01-18 06:54 PDT -------
After some hacking this week-end I found out WX had the same problem.
See WebCore/config.h :
// The defines in KeyboardCodes.h conflict with Windows as well, and the only
way I've found
// to address the problem is include KeyboarddCodes.h before windows.h, so do
it here.

I think other builds could suffer from that too. Moreover there don't seem to
be any drawback to adding those checks. Now that webkit-gtk is quite easy to
get working on win32, this patch would be more than welcome. It still applies
cleanly to trunk.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.