[Webkit-unassigned] [Bug 23332] Fix some skia pattern creation issues

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23332


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26732|review?(eric at webkit.org)    |review-
               Flag|                            |




------- Comment #2 from eric at webkit.org  2009-01-14 16:05 PDT -------
(From update of attachment 26732)
WebKit style doesn't put {} around single-line if clauses.

However in this case, it seems an early-return would be more appropriate.  if
normal repeating case can early-return a shader, and then no else is needed
after the return for the more complicated case (thus not indenting an extra 4
spaces).

Also, WebKit uses FIXME instead of TODO with no username attribution.

WebKit also doesn't wrap to 80cols like Google does.

I'm surprised bm2.eraseARGB(0x00, 0x00, 0x00, 0x00); doesn't take a color
argument instead.

WebKit's style is a bit strange (probably less so than Google's though), but at
least it's documented:
http://webkit.org/coding/coding-style.html

r- for the style issues.  Otherwise looks fine.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.