[Webkit-unassigned] [Bug 23318] click event listener remains registered after onclick attribute is removed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 14 09:32:55 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23318


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26710|review?                     |review-
               Flag|                            |




------- Comment #3 from darin at apple.com  2009-01-14 09:32 PDT -------
(From update of attachment 26710)
The first thing we need here is a test case to demonstrate the problem. The
details of the problem could be different with different node types, for
example, with the window. And the failure may be caused by some other code
change or some port-specific issue. A test case cuts through all those issues
and lets everyone see that something is really wrong.

The function responsible for handling this sort of thing is
EventTargetNode::removeInlineEventListenerForType. In the failing test case,
you should figure out if the problem is that function is not being called, or
if the that function is not working properly. Specifically, if you change the
value of the onclick attribute on a <button> element to the empty string (to
choose a specific example, because there are many different code paths), then:

    EventTargetNode::setOnclick will call
    EventTargetNode::setInlineEventListenerForType, which will call
    EventTargetNode::removeInlineEventListenerForType, which will remove the
listener that was added


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list